Allow _completion command to auto-complete it's arguments or their values
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice spotting. This might be achievable with less code: diff --git a/src/CompletionHandler.php b/src/CompletionHandler.php
index 0925df0..cce8fb4 100644
--- a/src/CompletionHandler.php
+++ b/src/CompletionHandler.php
@@ -103,6 +103,10 @@ class CompletionHandler
try {
$this->command = $this->application->find($cmdName);
+
+ // Create a new instance of the command to avoid any changes made by Command::run
+ $commandClass = get_class($this->command);
+ $this->command = new $commandClass();
} catch (\InvalidArgumentException $e) {
// Exception thrown, when multiple or none commands are found.
}I guess that doesn't cover cases where the constructor of a command has been changed though.. |
|
That might work, but the application won't be available from the command and we need to do |
aik099
force-pushed
the
46-unable-to-auto-complete-for-completion-command
branch
from
4d44526 to
d70320a
Compare
stecman
added a commit
that referenced
this pull request
May 13, 2015
…pletion-command Allow `_completion` command to auto-complete it's arguments or their values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the
CompletionCommandhas no arguments, but there might be added in #30. In that case without this PR the auto-complete forapp _completionargument won't work.In unit tests we're testing all parts separately, but we don't test by really invoking completion hook. That's why I don't know how do I test the changes I've made. All existing tests still pass.
Closes #46